Add multi management plane integration test#1157
Merged
Conversation
…read-only-file-plugin
…command-server-to-agent-config
…command-server-to-agent-config
…read-only-file-plugin
…read-only-file-plugin
…ent-plane-integration-test
sean-breen
reviewed
Jul 8, 2025
Makefile
Outdated
| PACKAGES_REPO=$(OSS_PACKAGES_REPO) TAG=${TAG} PACKAGE_NAME=$(PACKAGE_NAME) BASE_IMAGE=$(BASE_IMAGE) DOCKERFILE_PATH=$(OFFICIAL_IMAGE_DOCKERFILE_PATH) \ | ||
| OS_VERSION=$(OS_VERSION) OS_RELEASE=$(OS_RELEASE) IMAGE_PATH=$(IMAGE_PATH) \ | ||
| go test -v ./test/integration/managementplane | ||
| go test -v ./test/integration/managementplane ./test/integration/managementplane |
Contributor
There was a problem hiding this comment.
Should this be here twice?
Contributor
Author
There was a problem hiding this comment.
Nope should be ./test/integration/auxiliarycommandserver good catch Thank you!
craigell
approved these changes
Jul 10, 2025
craigell
approved these changes
Jul 10, 2025
sean-breen
approved these changes
Jul 10, 2025
dhurley
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Had to add specific lock for the manifest file as the auxiliary plugin could be reading the file while it is being updated by the command server.
Added integration tests with multiple management planes for: m
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)